-
Notifications
You must be signed in to change notification settings - Fork 288
x86: implemented _mm{,256}_maskload_epi{32,64} #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks great, thanks! r=me w/ tests and docs :) |
@alexcrichton tests and docs are ready. I will create new PR for mask stores, so you can merge this if everything is okay :) |
Hm, I have just noticed that I forgot about mask loads for |
@mrowqa Do you want to do that in a separate PR? That way we can just merge this now. |
It is fine to merge this now. I will implement the rest of masked loads in a new PR. I have changed the title to something more accurate. |
@mrowqa I think this may need a rebase now? |
Ah sorry about that! |
No worries. I wanted to contribute and you merged the changes anyway :) |
Hi,
just wanted to ask if I'm doing this in the right way. I will add the documentation and tests soon. Then I will also implement the mask stores.