Skip to content

x86: implemented _mm{,256}_maskload_epi{32,64} #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mrowqa
Copy link
Contributor

@mrowqa mrowqa commented Oct 25, 2017

Hi,

just wanted to ask if I'm doing this in the right way. I will add the documentation and tests soon. Then I will also implement the mask stores.

@alexcrichton
Copy link
Member

Looks great, thanks! r=me w/ tests and docs :)

@mrowqa
Copy link
Contributor Author

mrowqa commented Oct 25, 2017

@alexcrichton tests and docs are ready. I will create new PR for mask stores, so you can merge this if everything is okay :)

@mrowqa
Copy link
Contributor Author

mrowqa commented Oct 25, 2017

Hm, I have just noticed that I forgot about mask loads for f32 and f64 (there was no TODO comment in avx2.rs). I will add them soon.

@BurntSushi
Copy link
Member

@mrowqa Do you want to do that in a separate PR? That way we can just merge this now.

@mrowqa mrowqa changed the title x86: implemented maskloads for avx2 x86: implemented _mm{,256}_maskload_epi{32,64} Oct 26, 2017
@mrowqa
Copy link
Contributor Author

mrowqa commented Oct 26, 2017

It is fine to merge this now. I will implement the rest of masked loads in a new PR. I have changed the title to something more accurate.
Edit: actually, _mm{,256}_maskload_{ps,pd} are implemented.

@alexcrichton
Copy link
Member

@mrowqa I think this may need a rebase now?

@mrowqa
Copy link
Contributor Author

mrowqa commented Oct 27, 2017

As I wrote in #155, it is based on this PR (#152) - that is why I asked you to merge this one before the second one. You have already merged commits from this PR, so it can be safely closed without merging.

@mrowqa mrowqa closed this Oct 27, 2017
@mrowqa mrowqa deleted the maskload-avx2-impl branch October 27, 2017 18:03
@alexcrichton
Copy link
Member

Ah sorry about that!

@mrowqa
Copy link
Contributor Author

mrowqa commented Oct 28, 2017

No worries. I wanted to contribute and you merged the changes anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants