Skip to content

Implement missing std::ops #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2017
Merged

Implement missing std::ops #177

merged 1 commit into from
Nov 13, 2017

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Nov 6, 2017

Implements missing std::ops and adds test for all operators of all vector types.

Blocked on rust-lang/rust#45804

@BurntSushi
Copy link
Member

This LGTM, but it looks like simd_rem isn't a thing?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 6, 2017

@BurntSushi this PR is blocked on rust-lang/rust#45804 which implements simd_rem and the missing simd_divs.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 13, 2017

This is ready.

BurntSushi
BurntSushi approved these changes Nov 13, 2017
View reviewed changes
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit 663cf64 into rust-lang:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnzlbg @BurntSushi