syn API breaking change #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p32blo
reviewed
Nov 10, 2017
| let attrs = match item { | ||
| syn::Item::Fn(ref item) => &item.attrs, | ||
| _ => panic!("item must be a function!"), | ||
| }.iter() |
There was a problem hiding this comment.
Can this be done like this?
let attrs = func.attrs.iter()I really don't know a lot about syn but it looks like the match with item is done previously and you can already access the attrs from func.
|
I can't update this before tomorrow so feel free to pick it up if you want
this fixed sooner :)
…On Fri 10. Nov 2017 at 17:13, David Tolnay ***@***.***> wrote:
***@***.**** commented on this pull request.
Consider also pinning to a particular git commit using rev
<http://doc.crates.io/specifying-dependencies.html#specifying-dependencies-from-git-repositories>.
There are definitely other API changes coming as we converge on a real
release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#189 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3NpocB1Dh-t6ovK14JZGVeBnyMQxHqks5s1HYRgaJpZM4QZjJM>
.
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syn API changed in the following commit breaking our builds: dtolnay/syn@c6b55bc
This commit fixes it by using the new API.