Apply snap of bootstrap compiler in rust-lang/rust #796
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Ah just as a note here this isn't actually needed quite yet (probably Wednesday, Tuesday) but I presume it's good to get the ball rolling nevertheless. |
|
Ah, I've come up with a work around by disabling |
|
@bors: r+ |
|
📌 Commit df0401c has been approved by |
Apply snap of bootstrap compiler in rust-lang/rust FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).
|
💥 Test timed out |
|
@Mark-Simulacrum it appears that azure doesn't run on PRs, and bors doesn't work with Azure - I don't have a timeline for when this will be fixed. Until then stdarch is not merging anything :/ |
|
We'll want to land this (perhaps by just directly merging) within the next few days for sure, since the hack I invented to work around it in rust-lang/rust is not long-term tenable. |
|
I've raised the issue with infra. The libc repo is also blocked due to Azure Pipelines failing. |
|
@bors: r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit df0401c has been approved by |
Apply snap of bootstrap compiler in rust-lang/rust FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).
|
@bors delegate=@pietroalbini |
|
✌️ @@pietroalbini can now approve this pull request |
|
@bors delegate=pietroalbini |
|
✌️ @pietroalbini can now approve this pull request |
|
💥 Test timed out |
|
@bors retry |
|
@bors retry pls |
Apply snap of bootstrap compiler in rust-lang/rust FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).
|
💔 Test failed - status-azure |
|
@bors retry |
Apply snap of bootstrap compiler in rust-lang/rust FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).
|
💥 Test timed out |
|
Well, this is a legit timeout. |
|
@bors: retry |
Apply snap of bootstrap compiler in rust-lang/rust FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).
|
💔 Test failed - status-azure |
|
@bors: retry |
Apply snap of bootstrap compiler in rust-lang/rust FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).
|
50min later, 4 out of 18 jobs are done, and right now none of the remaining jobs is actually running... "Waiting for an available agent". |
|
This is a known problem. For a smooth libc workflow we would need 20
concurrent jobs. This was eating the 70 job queue of rust-lang/rust. Now we
have a 10 concurrent job queue for libc and other similar projects. That
solved the rust-Lang/rust problem, but made everything else worse.
Worst part, pretty much constantly we have ~2 Rust-Lang/rust PRs blocked on
libc or stdarch fixes that take days to merge because we have too few jobs.
|
|
💥 Test timed out |
|
@bors: retry |
Apply snap of bootstrap compiler in rust-lang/rust FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).
|
💔 Test failed - status-azure |
|
@bors: retry |
Apply snap of bootstrap compiler in rust-lang/rust FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).
|
☀️ Test successful - checks-cirrus-freebsd, status-azure |
FWIW, in the future we should try to avoid this as I'm assuming we'll break CI trying to land this here (and we can't swap bootstrap compilers in Rust until this lands).