Verify that all intrinsics have a run-time test #799
Conversation
|
@gnzlbg: no appropriate reviewer found, use r? to override |
| for mut item in file.items.drain(..) { | ||
| match item { | ||
| syn::Item::Fn(f) => functions.push((f, path)), | ||
| syn::Item::Mod(ref mut m) => { |
There was a problem hiding this comment.
stdsimd-verify did not scan for function items within inline modules (mod { ... }) - since tests are inside a mod tests { ... } this is required to add them.
| @@ -3437,7 +3437,7 @@ mod tests { | |||
| } | |||
|
|
|||
| #[simd_test(enable = "sse")] | |||
| pub unsafe fn test_mm_cvtsi32_ss() { | |||
| unsafe fn test_mm_cvtsi32_ss() { | |||
There was a problem hiding this comment.
These tests were pub items for some reason and the check errored that they also needed tests..
| if !rust.has_test { | ||
| // FIXME: this list should be almost empty | ||
| let skip = [ | ||
| "__readeflags", |
There was a problem hiding this comment.
We should try to make this list smaller over time. It might well be that some of these are already tested in other tests, or that the test names have typos or similar.
|
@bors: r+ |
|
📌 Commit f9326bb has been approved by |
Verify that all intrinsics have a run-time test Add a check to stdsimd-verify to check that all intrinsics have a run-time test. This is not the case right now, but we should at least not add intrinsics without tests.
|
☀️ Test successful - checks-cirrus-freebsd, status-azure |
Add a check to stdsimd-verify to check that all intrinsics have a run-time test. This is not the case right now, but we should at least not add intrinsics without tests.