Skip to content

Avx512 #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 4, 2020
Merged

Avx512 #891

merged 17 commits into from
Sep 4, 2020

Conversation

minybot
Copy link
Contributor

@minybot minybot commented Sep 3, 2020

fmadd: ps,pd
fnmadd: ps,pd
fmsub: ps,pd
fnmsub: ps,pd
fmaddsub: ps,pd
fmsubadd: ps,pd

add_round: ps,pd
sub_round: ps,pd
mul_round: ps,pd
div_round: ps,pd
sqrt_round: ps,pd

cvt_roundps_epi32
cvt_roundps_epu32

@rust-highfive
Copy link

r? @Amanieu

(rust_highfive has picked a reviewer for you, use r? to override)

@minybot
Copy link
Contributor Author

minybot commented Sep 3, 2020

_mm512_fmsub_ps can be vfmadd132ps or vfmadd213ps or vfmadd231ps.
In x86_64-unknown-linux-gnu, it uses vfmadd213ps.
In x86_64-pc-windows-msvc, it uses vfmadd231ps.
Does it support something like assert_instr(vfmadd213ps|vfmadd231ps)?

@Amanieu
Copy link
Member

Amanieu commented Sep 4, 2020

assert_instr can match a prefix, so you can use assert_instr(vfmadd). Please add a comment next to it to explain that the compiler can generate different instructions for this intrinsic.

@Amanieu
Copy link
Member

Amanieu commented Sep 4, 2020

For rounding modes can you do the same thing as the constify_imm5_sae macro: we want to panic in case of an invalid rounding mode since that could crash the compiler if we let it through to the LLVM intrinsic.

@Amanieu Amanieu merged commit d89c38b into rust-lang:master Sep 4, 2020
@minybot minybot deleted the avx512 branch September 5, 2020 00:23
@jrmuizel
Copy link
Contributor

jrmuizel commented Sep 7, 2020

It looks like this broke the check-style tests. It wasn't caught before merge because check-style passes without checking anything if there's no rustfmt available for the particular nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants