Skip to content

C/QotW + notable changes #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

C/QotW + notable changes #3336

merged 2 commits into from
Jun 9, 2022

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Jun 8, 2022

No description provided.

@llogiq
Copy link
Contributor Author

llogiq commented Jun 8, 2022

No idea why the markdown check fails. Perhaps someone can help?

@ericseppanen
Copy link
Contributor

No idea why the markdown check fails. Perhaps someone can help?

I will have a look.

@ericseppanen
Copy link
Contributor

ericseppanen commented Jun 8, 2022

The error is because of this line:

* [implement `[OsStr]::join`](https://github.com/rust-lang/rust/pull/96881)

That should be valid markdown, except that Python-Markdown <= 3.3.6 doesn't parse it correctly, which results in an empty list-item in the output, instead of the link we asked for.

This was seen previously as #2781. Since it would silently show up broken on the site, I added a CI check for empty list-items in the output.

I see that Python-Markdown 3.3.7 has been released (which I think should have the fix), but until we get that integrated into the site deployment workflow, my workaround is to add a useless &nbsp; to the offending line, i.e.

* [implement `[OsStr]::join`](https://github.com/rust-lang/rust/pull/96881) &nbsp;

@nellshamrell
Copy link
Contributor

nellshamrell commented Jun 9, 2022

Doing the workaround for now, but will take a look at upgrading (ty filing the issue!) later this week

@nellshamrell nellshamrell merged commit b9fa1b8 into rust-lang:master Jun 9, 2022
@llogiq llogiq deleted the twir-446 branch June 15, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants