Skip to content

Bring concerns visual to modern GitHub UI feature #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 30, 2025

@jieyouxu and I had a long and productive discussions about the visual of concerns, and in particular the fact that they can be buried in a wall of text, see rust-lang/compiler-team#864 (comment) as an example.

We therefor iterated to multiple design and ideas, and we end-up makes 3 choices to drastically improve the visual:

  1. the all section is placed inside a [!CAUTION] or [!NOTE]
  2. the number of active concerns is put next to the title, ie. Concerns (3 active)
  3. we removed the author from the display
    • as it doesn't seems to bring much and can be detrimental to the readability, particularly when a concern is resolved (can still be fetch by just clicking on the issue comment)

Caution

Concerns (1 active)

Managed by @rustbot—see help for details.


Note

Concerns (0 active)

Managed by @rustbot—see help for details.

@Urgau Urgau requested a review from Kobzol May 30, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant