Bring concerns visual to modern GitHub UI feature #2030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jieyouxu and I had a long and productive discussions about the visual of concerns, and in particular the fact that they can be buried in a wall of text, see rust-lang/compiler-team#864 (comment) as an example.
We therefor iterated to multiple design and ideas, and we end-up makes 3 choices to drastically improve the visual:
[!CAUTION]
or[!NOTE]
Concerns (3 active)
Caution
Concerns (1 active)
This is a resolved concernresolved in this commentManaged by
@rustbot
—see help for details.Note
Concerns (0 active)
This is a resolved concernresolved in this commentManaged by
@rustbot
—see help for details.