Skip to content

Update Favicon #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Update Favicon #1005

merged 2 commits into from
Feb 5, 2020

Conversation

XAMPPRocky
Copy link
Member

@XAMPPRocky XAMPPRocky commented Feb 4, 2020

As followup to #1003 I've updated all the favicon images and manifest to look better across browsers, in particular Safari. I've included GitHub in the comparison as a baseline. This PR also removes any unused images in static/images.

Safari (GitHub/Old/New)

Screenshot 2020-02-04 at 10 10 26

Chrome (GitHub/Old/New)

Screenshot 2020-02-04 at 10 11 01

Firefox (GitHub/Old/New)

Screenshot 2020-02-04 at 10 11 45

iOS Bookmark (Old/New)

IMG_1332

@pietroalbini
Copy link
Member

pietroalbini commented Feb 4, 2020

Is the third screenshot Firefox? (lol gh's automatic page updates are flaky)

Looks good to me! The favicon will need to be updated across all our websites as well.

@Manishearth Manishearth merged commit 10570df into rust-lang:master Feb 5, 2020
@XAMPPRocky XAMPPRocky deleted the update-favicon branch February 5, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants