-
Notifications
You must be signed in to change notification settings - Fork 215
Fix Create Disk Image Example #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Create Disk Image Example #300
Conversation
The example code didn't compile. This patch fixes that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Looks like I forgot to try this snippet.
One minor nit: I think the Path::new
call is simple enough to do apply it in the out_dir
/kernel
bindings directly instead of introducing new out_dir_path
/kernel_path
bindings. I left some suggestions below for this.
@phil-opp I agree, that looks simpler. EDIT: now I remember why I did it that way. The compiler complains about
If you have a different way, let me know |
Hello, I think that in the Cargo.toml file you should change |
I think we can use
Thanks, done in 0d24cef. |
Could you try whether the new version works for you? Then we can finally merge this! |
The new version is working very good, thanks! |
Ok great, thanks for testing! |
The example code didn't compile. This patch fixes that.
Let me know if it needs any changes, and thanks for making this awesome crate!