Skip to content

fix(deallocate_middle): advance to next in try_insert_after #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

haraldh
Copy link
Contributor

@haraldh haraldh commented Jun 29, 2022

If the next hole node is still lower than the hole to be added, advance the cursor to the next in the list.

For this to trigger, this patch modifies the deallocate_middle() test.
It requires two holes in the list before the one to be deallocated.

Signed-off-by: Harald Hoyer [email protected]

If the next hole node is still lower than the hole to be added, advance
the cursor to the next in the list.

For this to trigger, this patch modifies the `deallocate_middle()` test.
It requires two holes in the list before the one to be deallocated.

Signed-off-by: Harald Hoyer <[email protected]>
@haraldh haraldh changed the title fix(deallocate_middle): skip to next in try_insert_after fix(deallocate_middle): advance to next in try_insert_after Jun 29, 2022
@jamesmunns
Copy link
Collaborator

Hey @haraldh, I think I just hit the same issue in #64, I'll be adding more tests.

Sorry for the issue!

@phil-opp phil-opp mentioned this pull request Jul 6, 2022
@jamesmunns
Copy link
Collaborator

Superceded by #64, thank you for reporting @haraldh!

@jamesmunns jamesmunns closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants