Multiboot2: More Safety for Getters of Strings from Tags (Prepare Release v0.14.0) #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #22 we do not want to rely on bootloaders following the specification in every case. Thus, this PR adds more safety for when parsing strings from tags.
phip1611
changed the title
Streamline the string getters from RSDP tags with the previous changes to multiboot2 tags.
phip1611
force-pushed
the
multiboot2-str-safety
branch
from
19c7e8e to
417689b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve safety when parsing strings from Tags + general code improvements.