MSRV bump + rust edition 2021 + typos check in CI

.github/workflows/qa.yml

@@ -0,0 +1,12 @@
+name: QA
+
+on: [ push, pull_request ]
+
+jobs:
+  spellcheck:
+    name: Spellcheck
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v3
+      # Executes "typos ."
+      - uses: crate-ci/[email protected]

.github/workflows/rust.yml

@@ -17,9 +17,9 @@ jobs:
         rust:
           - stable
           - nightly
-          - 1.52.1 # MSVR
+          - 1.56.1 # MSVR
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       # Important preparation step: override the latest default Rust version in GitHub CI
       # with the current value of the iteration in the "strategy.matrix.rust"-array.
       - uses: actions-rs/toolchain@v1
@@ -41,9 +41,9 @@ jobs:
         rust:
           - stable
           - nightly
-          - 1.52.1 # MSVR
+          - 1.56.1 # MSVR
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       # Important preparation step: override the latest default Rust version in GitHub CI
       # with the current value of the iteration in the "strategy.matrix.rust"-array.
       - uses: actions-rs/toolchain@v1
@@ -65,9 +65,9 @@ jobs:
     strategy:
       matrix:
         rust:
-          - 1.52.1 # MSVR
+          - 1.56.1 # MSVR
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       # Important preparation step: override the latest default Rust version in GitHub CI
       # with the current value of the iteration in the "strategy.matrix.rust"-array.
       - uses: actions-rs/toolchain@v1

.typos.toml

@@ -0,0 +1,13 @@
+# Configuration for the typos spell checker utility (<https://github.com/crate-ci/typos>).
+
+[files]
+extend-exclude = [
+    # "uefi/src/table/boot.rs"
+]
+
+[default.extend-words]
+Rela = "Rela"
+
+[default.extend-identifiers]
+# FOOBAR = "FOOBAR"
+

multiboot2-header/Cargo.toml

@@ -9,7 +9,7 @@ authors = [
     "Philipp Schuster <[email protected]>"
 ]
 license = "MIT/Apache-2.0"
-edition = "2018"
+edition = "2021"
 categories = [
     "no-std",
     "parsing",

multiboot2-header/Changelog.md

@@ -1,5 +1,8 @@
 # CHANGELOG for crate `multiboot2-header`
 
+## Unreleased
+- MSRV is 1.56.1
+
 ## v0.2.0 (2022-05-03)
 - **BREAKING** renamed `EntryHeaderTag` to `EntryAddressHeaderTag`
 - **BREAKING** some paths changed from `multiboot2_header::header` to `multiboot2_header::builder`

multiboot2-header/README.md

@@ -68,7 +68,7 @@ You may need a special linker script to place this in a LOAD segment with a file
 See specification.
 
 ## MSRV
-The MSRV is 1.52.1 stable.
+The MSRV is 1.56.1 stable.
 
 ## License & Contribution
 

multiboot2-header/src/builder/information_request.rs

@@ -21,7 +21,6 @@ pub struct InformationRequestHeaderTagBuilder {
 #[cfg(feature = "builder")]
 impl InformationRequestHeaderTagBuilder {
     /// New builder.
-    #[allow(clippy::missing_const_for_fn)] // TODO remove once MSRV is higher than 1.52.1
     pub fn new(flag: HeaderTagFlag) -> Self {
         Self {
             irs: BTreeSet::new(),
@@ -31,7 +30,6 @@ impl InformationRequestHeaderTagBuilder {
 
     /// Returns the expected length of the information request tag,
     /// when the `build`-method gets called.
-    #[allow(clippy::missing_const_for_fn)] // TODO remove once MSRV is higher than 1.52.1
     pub fn expected_len(&self) -> usize {
         let basic_header_size = size_of::<InformationRequestHeaderTag<0>>();
         let req_tags_size = self.irs.len() * size_of::<MbiTagType>();
@@ -76,7 +74,7 @@ impl InformationRequestHeaderTagBuilder {
 
         for tag in &self.irs {
             let bytes: [u8; 4] = (*tag as u32).to_ne_bytes();
-            data.extend(&bytes);
+            data.extend(bytes);
         }
 
         debug_assert_eq!(

multiboot2-header/src/lib.rs

@@ -31,7 +31,7 @@
 //! ```
 //!
 //! ## MSRV
-//! The MSRV is 1.52.1 stable.
+//! The MSRV is 1.56.1 stable.
 
 #![no_std]
 #![deny(rustdoc::all)]

multiboot2/Cargo.toml

@@ -14,7 +14,7 @@ authors = [
     "Philipp Schuster <[email protected]>"
 ]
 license = "MIT/Apache-2.0"
-edition = "2018"
+edition = "2021"
 categories = [
     "no-std",
     "parsing",

multiboot2/Changelog.md

@@ -1,5 +1,8 @@
 # CHANGELOG for crate `multiboot2`
 
+## Unreleased
+- MSRV is 1.56.1
+
 ## 0.14.1 (2023-03-09)
 - fixed the calculation of the last area of the memory map tag ([#119](https://github.com/rust-osdev/multiboot2/pull/119))
   (Previously, iterating the EFI Memory map resulted in a superfluous entry as it ran over the next tag)

multiboot2/README.md

@@ -31,7 +31,7 @@ other fields  | variable
 All tags and the mbi itself are 8-byte aligned. The last tag must be the _end tag_, which is a tag of type `0` and size `8`.
 
 ## MSRV
-The MSRV is 1.52.1 stable.
+The MSRV is 1.56.1 stable.
 
 ## License & Contribution
 

multiboot2/src/lib.rs

@@ -32,7 +32,7 @@
 //! ```
 //!
 //! ## MSRV
-//! The MSRV is 1.52.1 stable.
+//! The MSRV is 1.56.1 stable.
 
 // this crate can use std in tests only
 #[cfg_attr(test, macro_use)]
@@ -108,7 +108,7 @@ pub const MULTIBOOT2_BOOTLOADER_MAGIC: u32 = 0x36d76289;
 ///   environment (segfault) but also in UEFI-applications, where the referenced
 ///   memory is not (identity) mapped (UEFI does only identity mapping).
 /// * The memory at `address` must not be modified after calling `load` or the
-///   program may observe unsychronized mutation.
+///   program may observe unsynchronized mutation.
 pub unsafe fn load(address: usize) -> Result<BootInformation, MbiLoadError> {
     load_with_offset(address, 0)
 }
@@ -131,7 +131,7 @@ pub unsafe fn load(address: usize) -> Result<BootInformation, MbiLoadError> {
 ///   environment (segfault) but also in UEFI-applications, where the referenced
 ///   memory is not (identity) mapped (UEFI does only identity mapping).
 /// * The memory at `address` must not be modified after calling `load` or the
-///   program may observe unsychronized mutation.
+///   program may observe unsynchronized mutation.
 pub unsafe fn load_with_offset(
     address: usize,
     offset: usize,

multiboot2/src/rsdp.rs

@@ -29,7 +29,7 @@ pub struct RsdpV1Tag {
 }
 
 impl RsdpV1Tag {
-    /// The "RSD PTR " marker singature.
+    /// The "RSD PTR " marker signature.
     ///
     /// This is originally a 8-byte C string (not null terminated!) that must contain "RSD PTR "
     pub fn signature(&self) -> Result<&str, Utf8Error> {

multiboot2/src/vbe_info.rs

@@ -233,7 +233,7 @@ impl fmt::Debug for VBEModeInfo {
 
 /// A VBE colour field.
 ///
-/// Descirbes the size and position of some colour capability.
+/// Describes the size and position of some colour capability.
 #[derive(Debug, PartialEq, Eq, Copy, Clone)]
 #[repr(C, packed)]
 pub struct VBEField {