uefi: Fix return value lifetime for register_protocol_notify #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the rules of lifetime elision (https://doc.rust-lang.org/reference/lifetime-elision.html), the lifetime of the `SearchType` returned from `register_protocol_notify` was infered to be the lifetime of `Self`. The correct lifetime is the `protocol` reference.
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the rules of lifetime elision
(https://doc.rust-lang.org/reference/lifetime-elision.html), the lifetime of the
SearchTypereturned fromregister_protocol_notifywas infered to be the lifetime ofSelf. The correct lifetime is theprotocolreference.In practice this isn't likely to matter much to users, but I noticed it due to a compilation error when working on #893
Checklist