Skip to content

uefi-raw: Move EFI_SIMPLE_NETWORK_PROTOCOL #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

uefi-raw: Move EFI_SIMPLE_NETWORK_PROTOCOL #1634

merged 1 commit into from
Apr 15, 2025

Conversation

JarlEvanson
Copy link
Contributor

Move the raw definition of EFI_SIMPLE_NETWORK_PROTOCOL to the uefi-raw crate.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

phip1611
phip1611 requested changes Apr 15, 2025
View reviewed changes
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I think you already switched a few bool to the ABI-compatible Boolean type, which is perfectly fine and right! But can you please adjust this consistently? I think you missed a few places

@phip1611 phip1611 added this pull request to the merge queue Apr 15, 2025
Merged via the queue into rust-osdev:main with commit 4248ee8 Apr 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JarlEvanson @phip1611