Slight redesign of the raw framebuffer interface #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a different take on the direct framebuffer interface:
GraphicsOutput::framebuffer()
is perfectly safe per se in the sense that there is no incorrect input or wrong call circumstance that will cause it to do unsafe things. It is the caller who is going unsafe by writing into the framebuffer after that.Longer-term, the interface could be improved further by providing a more ergonomic way to do volatile writes (which would feel closer to the original slice abstraction).