Closed
Description
We have a few changes coming up (#425, #414 , #432) which will make the following changes to the compatibility of this crate:
- Increase the Minimum Supported Rust Version (MSRV) from 1.36 (released July 4, 2019) to 1.56 (released October 21, 2021).
- Increase the supported OS version of
*-pc-windows-{gnu,msvc}
from Windows Vista (released November 30, 2006) to Windows 10 (released July 15, 2015).- Rust increased its minimum Windows OS version from Windows 7 to Windows 10 in February 26th, 2024.
- Older versions of Windows are still supported under the
x86_64-win7-windows-msvc
andi686-win7-windows-msvc
targets - We would intend to continue to support the
*-win7-*
targets (viaRtlGenRandom
)
- We are not making any changes to the API of this crate
- We are not making any changes to the features of this crate
The Rust Semver Compatibility Guide does not specify if such actions would be breaking changes. Both:
are listed as "Possibly-breaking" changes.
My personal preference would be to release these changes as 0.2.16
(not consider this a breaking change) because:
getrandom
is widely used throughout the Rust ecosystem so updating all callers can be somewhat tedious.- It's not clear how a user can have a
custom
implementation work with both versions ofgetrandom
. - Both the MSRV increases and the Windows platform increases are less disruptive than an Semver-breaking change.
However, if we do decide to have this be a breaking change, we should discuss if there are any other semver-breaking changes we wish to make (see #346 and #230). Another option would just be to get consensus on #232 and release these changes as 1.0
Metadata
Metadata
Assignees
Labels
No labels