Skip to content

Update label and prep details, new endpoints #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

abrihter
Copy link
Contributor

@abrihter abrihter commented Oct 26, 2024

Try to align with Fulfillment Inbound API Update: Fulfillment Inbound API v2024-03-20 Now Supports Preparation Details as per documentation

Added new endpoints:

Summary by Sourcery

Add new endpoints to the Fulfillment Inbound API for creating marketplace item labels, listing preparation details, and setting preparation details for MSKUs. Align the API with the latest version to support preparation details.

New Features:

  • Introduce a new endpoint to create marketplace item labels, allowing users to generate labels for a list of MSKUs in a specified marketplace.
  • Add a new endpoint to list preparation details for a list of MSKUs, providing users with the ability to retrieve prep details in a specified marketplace.
  • Implement a new endpoint to set preparation details for a list of MSKUs, enabling users to define prep details in a specified marketplace.

Enhancements:

  • Align the Fulfillment Inbound API with the latest version, supporting preparation details as per the updated documentation.

Copy link

sourcery-ai bot commented Oct 26, 2024

Reviewer's Guide by Sourcery

This PR updates the FulfillmentInbound API client to support new endpoints for preparation details and marketplace item labels. The changes align with the Fulfillment Inbound API v2024-03-20 update.

Class diagram for updated FulfillmentInbound API client

classDiagram
    class FulfillmentInbound {
        +create_marketplace_item_labels(**kwargs) ApiResponse
        +list_prep_details(**kwargs) ApiResponse
        +set_prep_details(**kwargs) ApiResponse
    }
    note for FulfillmentInbound "New methods added for handling marketplace item labels and preparation details."
Loading

File-Level Changes

Change Details Files
Added new endpoints for managing item labels and preparation details
  • Added create_marketplace_item_labels endpoint for generating labels for MSKUs
  • Added list_prep_details endpoint to retrieve preparation details for MSKUs
  • Added set_prep_details endpoint to update preparation details for MSKUs
sp_api/api/fulfillment_inbound/fulfillment_inbound.py
Code formatting improvements
  • Removed trailing whitespace throughout the file
  • Fixed indentation and spacing
sp_api/api/fulfillment_inbound/fulfillment_inbound.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abrihter - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@saleweaver saleweaver merged commit 35217a5 into saleweaver:master Oct 26, 2024
3 checks passed
@saleweaver
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants