Skip to content

fix(angular/autocomplete): don't handle enter events with modifier keys #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

jeripeierSBB
Copy link
Collaborator

Doesn't handle ENTER key presses and doesn't prevent their default action,
if they have a modifier, in order to avoid interfering with any OS-level shortcuts.
angular/components#14717

Doesn't handle `ENTER` key presses and doesn't prevent their default action,
if they have a modifier, in order to avoid interfering with any OS-level shortcuts.
angular/components#14717
@github-actions
Copy link

Staging ready from ab0496a at 1/17/2022, 8:01:06 AM:

Copy link
Collaborator

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB jeripeierSBB merged commit 657cdb3 into master Jan 17, 2022
@jeripeierSBB jeripeierSBB deleted the autocomplete-fix branch January 17, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants