Skip to content

Use Hardhat client and ethers in unit tests #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Feb 4, 2024

  • Replaces ganache client with a Hardhat provider in unit tests
  • Replaces truffle-contract with ethers in unit tests
  • Removes truffle/contract depedency

In tests that revert, the hit counts have had to be adjusted downwards because truffle-contract re-executed the transaction as a call to fetch the revert reason.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3c5615) 95.85% compared to head (35f0d20) 95.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #847   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          19       19           
  Lines        1061     1061           
=======================================
  Hits         1017     1017           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke mentioned this pull request Feb 4, 2024
11 tasks
@cgewecke cgewecke merged commit 6739db6 into master Feb 4, 2024
@cgewecke cgewecke deleted the units-use-hardhat branch February 4, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants