Move more packages into `dom`

[japgolly]

Move the following into dom:

• beacon
• crypto
• deviceorientation
• domparser
• gamepad
• mediastream
• permissions
• push
• serviceworkers
• sharedworkers
• storage
• webrtc

This should leave us with the following packages:

• intl
• webgl

[japgolly]

Decided to count LoC:

for f in \
  src/main/scala/org/scalajs/dom/crypto \
  src/main/scala/org/scalajs/dom/experimental/beacon \
  src/main/scala/org/scalajs/dom/experimental/cachestorage \
  src/main/scala/org/scalajs/dom/experimental/deviceorientation \
  src/main/scala/org/scalajs/dom/experimental/domparser \
  src/main/scala/org/scalajs/dom/experimental/gamepad \
  src/main/scala/org/scalajs/dom/experimental/intl \
  src/main/scala/org/scalajs/dom/experimental/mediastream \
  src/main/scala/org/scalajs/dom/experimental/permissions \
  src/main/scala/org/scalajs/dom/experimental/push \
  src/main/scala/org/scalajs/dom/experimental/serviceworkers \
  src/main/scala/org/scalajs/dom/experimental/sharedworkers \
  src/main/scala/org/scalajs/dom/experimental/storage \
  src/main/scala/org/scalajs/dom/experimental/webgl \
  src/main/scala/org/scalajs/dom/experimental/webrtc \
  ; do
  l="$(cloc $f | tail -2 | head -1 | awk '{print $5}')"
  echo "$f  -- $l"
done

which yielded unexpected results:

src/main/scala/org/scalajs/dom/crypto  -- 569
src/main/scala/org/scalajs/dom/experimental/beacon  -- 20
src/main/scala/org/scalajs/dom/experimental/cachestorage  -- 40
src/main/scala/org/scalajs/dom/experimental/deviceorientation  -- 50
src/main/scala/org/scalajs/dom/experimental/domparser  -- 21
src/main/scala/org/scalajs/dom/experimental/gamepad  -- 43
src/main/scala/org/scalajs/dom/experimental/intl  -- 161
src/main/scala/org/scalajs/dom/experimental/mediastream  -- 376
src/main/scala/org/scalajs/dom/experimental/permissions  -- 60
src/main/scala/org/scalajs/dom/experimental/push  -- 81
src/main/scala/org/scalajs/dom/experimental/serviceworkers  -- 199
src/main/scala/org/scalajs/dom/experimental/sharedworkers  -- 28
src/main/scala/org/scalajs/dom/experimental/storage  -- 23
src/main/scala/org/scalajs/dom/experimental/webgl  -- 260
src/main/scala/org/scalajs/dom/experimental/webrtc  -- 361

Surprisingly the biggest packages seem to be:

569 - src/main/scala/org/scalajs/dom/crypto
376 - src/main/scala/org/scalajs/dom/experimental/mediastream
361 - src/main/scala/org/scalajs/dom/experimental/webrtc
260 - src/main/scala/org/scalajs/dom/experimental/webgl
199 - src/main/scala/org/scalajs/dom/experimental/serviceworkers
161 - src/main/scala/org/scalajs/dom/experimental/intl

So actually I think there are two good choices we could make:

• packages with loc (or maybe type count) > n keep their packages?
• just chuck everything in dom?

@sjrd @armanbilge: Thoughts?

[japgolly]

I think my opinion here is to just put everything in dom. Like @sjrd said, the real dom API isn't namespaced so maybe we're just creating work for ourselves for no real benefit that I can think of atm.

[japgolly]

Thinking towards an auto-generated future, this is also good. Since generators wouldn't know about our namespaces without manual interventions.

@armanbilge also had a good point in favour of no namespaces ^^

[armanbilge]

just chuck everything in dom

My vote 👍

[armanbilge]

Btw, can this happen at the same time as #476?

[sjrd]

+1 for putting everything in dom. It seems simpler.

Btw, can this happen at the same time as #476?

I would advise against it. Moving without splitting can be done with almost zero impact on the git history, while it has an impact on the real code. Splitting without moving has no impact on the code, but destroys the git history. If you do both at the same time, you get a commit that is horrible to review and horrible to debug in a git blame situation.

[armanbilge]

Splitting without moving has no impact on the code, but destroys the git history.

That's a really important point, especially if/while we are still merging things up from series/1.x into main.

[armanbilge]

@japgolly Ths is the last major binary-breaking change we have to make before we can release 2.0 right?

[japgolly]

Nah there's this, there's 545, but I'm also planning on submitting a PR around IDB and maybe some other things but definitely hoping to get 2.0 soon! Hopefully within 2 weeks :)

[japgolly]

oh lol this is #545 hahah