Make Blob compliance with documentation #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabioPinheiro
commented
Oct 7, 2019
|
@sjrd Can I have feedback on the PR? |
japgolly
reviewed
Aug 20, 2021
| @@ -2534,9 +2534,12 @@ raw/BiquadFilterNode[JT] val numberOfOutputs: Int | |||
| raw/BiquadFilterNode[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit | |||
| raw/BiquadFilterNode[JT] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit | |||
| raw/BiquadFilterNode[JT] var `type`: String | |||
| raw/Blob[JC] def close(): Unit | |||
There was a problem hiding this comment.
Not actually removed, just moved down a line
armanbilge
approved these changes
Aug 20, 2021
|
@armanbilge Ready for review and merge. @FabioPinheiro I know it's been two years since you submitted this and sorry for such a long delay. @armanbilge and I are helping out to improve response times going forward. Thanks so much for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/Blob
Add missing methods on Blob
Update the documentation
Remove the close method