Setup CI release #475
Setup CI release #475
Conversation
build.sbt
Outdated
| @@ -17,6 +17,14 @@ val commonSettings = Seq( | |||
| scalacOptions ++= Seq("-deprecation", "-feature", "-Xfatal-warnings") | |||
| ) | |||
|
|
|||
| val noPublishSettings = Seq( | |||
| skip in publish := true, | |||
There was a problem hiding this comment.
I believe in 1.5.5 this is all we need, all the rest is redundant stuff that I created years ago in the 0.13.x days, and now it seems to have spread around verbatim haha. Plus change to publish / skip
.github/workflows/release.yml
Outdated
| - uses: actions/[email protected] | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: olafurpg/setup-scala@v10 |
There was a problem hiding this comment.
13 is latest. I'll add dependabot for these later (or feel free to yourself if you want)
There was a problem hiding this comment.
Never used dependabot. My chance to learn! This is what you install? https://github.com/apps/dependabot-preview
.github/workflows/release.yml
Outdated
| env: | ||
| SCALAJS_VERSION: "${{ matrix.scalajsversion == '0.6.x' && '0.6.28' || '' }}" | ||
| steps: | ||
| - uses: actions/[email protected] |
There was a problem hiding this comment.
Just @v2, that way it will pick up compatible 2.x.x actions automatically.
|
Btw do you want to publish snapshots? |
There was a problem hiding this comment.
I was about to merge and then I thought I'd just do a quick comparison against boopickle and they've got this before the publish step:
- uses: actions/checkout@v2
- uses: olafurpg/setup-scala@v12
- uses: olafurpg/setup-gpg@v3
- uses: coursier/cache-action@v6I'm not fussed about the caching but can you pls also confirm whether we need setup-gpg?
.github/workflows/release.yml
Outdated
| tags: ["v*"] | ||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
ubuntu-latest probably better
Oops, you are right we don't. I remember you advised me to check with boopickle, my bad. Let me do that now. I think I copied this directly from the sbt-ci-release repo ... |
|
See sbt/sbt-ci-release#171 about |
|
Done! Thanks and nice work! |
|
@armanbilge The release-drafter stuff broke. It didn't run on this PR so we missed it https://github.com/scala-js/scala-js-dom/actions/runs/1122419282 |
|
Yeah I'm looking into it now. I copied it straight out of boopickle so not sure what's missing. Btw, we published our first snapshot! So seems that's working at least :) |
|
@japgolly ok, I don't have a clue sorry :( it says we are missing the |
|
@japgolly found it release-drafter/release-drafter#398 (comment) In short, the |
|
@armanbilge np disabled on |
Who could argue that sbt-gh-actions is preferable to this!! :P