Skip to content

Fix #488 HTMLMediaElement.play() should return Promise #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2021
Merged

Fix #488 HTMLMediaElement.play() should return Promise #491

merged 1 commit into from
Aug 20, 2021

Conversation

armanbilge
Copy link
Member

https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/play

The spec says:

Browsers released before 2019 may not return a value from play()

So I made the return value js.UndefOr[js.Promise[Unit]].

@armanbilge armanbilge changed the title Fix #488 HTMLAudioElement.play should return Promise Fix #488 HTMLMediaElement.play() should return Promise Aug 15, 2021
@japgolly japgolly self-requested a review August 20, 2021 03:09
@japgolly
Copy link
Contributor

Awesome @armanbilge LGTM

@japgolly japgolly merged commit 116cc24 into series/1.x Aug 20, 2021
@japgolly japgolly deleted the issue/488 branch August 20, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japgolly japgolly Awaiting requested review from japgolly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @japgolly