Revert hardcodes

[armanbilge]

@japgolly Sorry for messing it all up :(

[japgolly]

@armanbilge No problem at all, I'm sorry I wasn't clearer. I seem to be rushing a lot this year, I'll try to slow down a bit next time.

So just so we're on the same page, if we need to do a new 1.x release, we already have to create the tag manually locally, so let's just also add a commit directly to the branch being tagged, to set the version.

[japgolly]

Also @armanbilge , are you still good to do the release comms?

[armanbilge]

so let's just also add a commit directly to the branch being tagged, to set the version

Ahh, so this is what you did, that's why I couldn't find it. Also, I thought you would have published the release notes I drafted when you published. Well, I know now for next time, though hopefully this will be the last time.

are you still good to do the release comms?

I'll cover gitter, discord, scala-users, do you mind tweeting?

[armanbilge]

Also, I thought you would have published the release notes I drafted when you published.

Shoot, these just got overriden 😅

[japgolly]

I haven't looked into how the release notes stuff works, we have release notes now? How do we find them?

do you mind tweeting?

Yeah np, I'll do Twitter & Reddit but I'll wait to see about these release notes first

[armanbilge]

They are here: https://github.com/scala-js/scala-js-dom/releases

I wrote it up all nice, but it seems my idiot merges just now got them overriden by the release drafter. I'll write them up again.

[armanbilge]

@japgolly I drafted release notes, which you should be able to see at https://github.com/scala-js/scala-js-dom/releases. Please edit as you see fit and publish!

[armanbilge]

OMG, I am so stupid. I merged your dependabot PR and my release notes got overwritten again. And I still didn't save them!! 😠

[armanbilge]

Third times a charm 😬 Also saved them externally this time, just in case!

[japgolly]

Oh man, I feel your pain :(

[japgolly]

@armanbilge ok mate, release notes published and I did these comms below. I'll leave the other ones to you but we did it! Hehe, bit of stumbling around but it all worked out well in the end, and we'll improve for v2.0. Thanks for your help! I'm enjoying maintaining with you!

• https://twitter.com/japgolly/status/1431011200771379200?s=20
• https://old.reddit.com/r/scala/comments/pc9k5y/scalajsdom_120_released_this_is_the_first_release

[armanbilge]

Exciting!! 😆 yes it's been a real pleasure, thank you so much for including me! I'm learning so much too 😁 Towards v2 🚀

Yup, I'll take care of the other comms!