Clean up config traits #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not seem to correspond to any specified interface, and is not used anywhere.
So that they can be created in a type-safe way with the
`new Foo { ... }` syntax.
We also standardize on `Int` for all small-integer fields.
Previously, some fields were typed as `Short`, but not
consistently.
We deprecate all the `apply`-based constructors, which are now
redundant.
So that they can be created with the `new Foo { ... }` syntax.
We deprecated the `apply` constructors, which are now redundant.
This is mostly motivated by making config traits non-native JS
traits, so that they can be created with the `new Foo { ... }`
syntax.
We deprecated the `apply` constructors, since they are now
redundant.
There are some other changes along the way.
This is mostly motivated by making config traits non-native JS
traits, so that they can be created with the `new Foo { ... }`
syntax.
We deprecated the `apply` constructors, since they are now
redundant.
There are some other changes along the way.
Instead, make the corresponding traits non-native JS traits, so
that they can be created with the `new Foo { ... }` syntax.
armanbilge
approved these changes
Sep 19, 2021
There was a problem hiding this comment.
This is really great (thanks for continuing to contribute!!) and very huge ... honestly I skimmed most of the changes. A lot of this code I'll be revisiting anyway as we de-namespace.
@japgolly seems to be on a bit of a hiatus atm but hopefully he'll be back soon :)
japgolly
approved these changes
Sep 27, 2021
|
Fantastic changes, thanks @sjrd . LGTM |
|
@sjrd do you have any more planned/suggested cleanups for 2.0? I'm trying to get an idea of remaining blockers. Thanks! |
|
I'd like to have separate definitions of I think that's the only thing I have left. |
|
Thanks, let me pop that into an issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And deprecate all the
def apply-based constructors, in favor of thenew Foo { ... }syntax.