Restructure Java-style #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holy. Crap. Talk about coming back with a bang!! 😮 Hope everything is well btw ❤️ |
japgolly
commented
Sep 27, 2021
|
Note: this PR is more for feedback. I'll fix the issue I mentioned above and re-run this. |
|
Ok I think this is ready to go now. I did a quick skim of some of the huge 44k patch and didn't notice anything wrong. Also thanks for your previous comment @armanbilge |
armanbilge
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476
Performed automatically using https://github.com/japgolly/scala-restructure
Changes:
Notice that the API reports have no modifications which is a good sign.