Add InputEvent, StaticRange, AbstractRange
#695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Apr 16, 2022
|
After we land this one I'm hoping we can cut a v2.2.0, now that we've accumulated a handful of contributor PRs :) |
armanbilge
commented
May 6, 2022
|
Polite ping @japgolly :) if you don't have time to review for a while, no big deal, just let me know and I won't block v2.2.0 on this if that's okay with you! |
Oh my! Apologies @armanbilge ! I haven't been keeping up with my email lately so I missed this. I'll get to this very son |
|
No worries, whenever you get to it! I hope you don't mind I released v2.2.0, it was really wonderful to get a bunch of contributions and I wanted to get it out :) |
japgolly
requested changes
May 29, 2022
japgolly
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to add
InputEventand it sort of snowballed :)https://www.w3.org/TR/input-events-2/#interface-InputEvent-AttributesMDN links to this, which is different (?)
https://rawgit.com/w3c/input-events/v1/index.html#interface-InputEvent-Attributes