Skip to content

Add History#scrollRestoration #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

zetashift
Copy link
Contributor

Facade for https://developer.mozilla.org/en-US/docs/Web/API/History/scrollRestoration

If there is anything missing or wrong, let me know!

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good, just a couple Scaladoc nitpicks :)

@armanbilge armanbilge changed the title Add ScrollRestoration facade Add History#scrollRestoration Aug 20, 2022
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@armanbilge armanbilge merged commit ffcbaa9 into scala-js:main Aug 22, 2022
@zetashift zetashift deleted the add-facade/scrollrestoration branch January 27, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants