Rethink partest-as-a-module

[scabug]

Partest should uptake the Icode test that compares icode at two phases.

[scabug]

Imported From: https://issues.scala-lang.org/browse/SI-7836?orig=1
Reporter: @som-snytt

[scabug]

@gkossakowski said:
Relevant PR discussion: scala/scala#2859 (comment)

[scabug]

@retronym said (edited on Sep 24, 2013 10:22:18 AM UTC):
I'd vote to do precisely the opposite and move DirectTest (the parent class for IcodeComparison), out of the partest module and back into partest-extras. It depends on private API of the compiler and is not a reusable component.

[scabug]

@retronym said (edited on Sep 11, 2013 9:20:43 PM UTC):
Here's partest-extras today:

find src/partest-extras
src/partest-extras
src/partest-extras/scala
src/partest-extras/scala/tools
src/partest-extras/scala/tools/partest
src/partest-extras/scala/tools/partest/ASMConverters.scala
src/partest-extras/scala/tools/partest/AsmNode.scala
src/partest-extras/scala/tools/partest/BytecodeTest.scala
src/partest-extras/scala/tools/partest/instrumented
src/partest-extras/scala/tools/partest/instrumented/Instrumentation.scala
src/partest-extras/scala/tools/partest/instrumented/Profiler.java
src/partest-extras/scala/tools/partest/JavapTest.scala
src/partest-extras/scala/tools/partest/ReplTest.scala
src/partest-extras/scala/tools/partest/ScriptTest.scala
src/partest-extras/scala/tools/partest/SigTest.scala
src/partest-extras/scala/tools/partest/Util.scala

[scabug]

@retronym said:
See discussion: scala/scala-partest-interface#3 (comment)

Summary: we might want to make partest scala/scala private again.

[scabug]

@retronym said:
Here'e the first example of the tight coupling between partest and the compiler internals requiring some contortions:

xeno-by/scala@ca9b1e2

After we insource (or even after the next RC is published), we should remember to remove those workarounds.

[scabug]

@adriaanm said:
Maybe we'll revisit, but for now lets reflect what I believe is the consensus here.

[scabug]

@som-snytt said:
Does that mean partest is in or out?

[scabug]

@adriaanm said:
It's somewhere in the middle