-
Notifications
You must be signed in to change notification settings - Fork 1k
Document the pattern for evolving case classes in a compatible manner #2662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e54f7f1
Document the patter for evolving case classes in a compatible manner
sideeffffect 5c8df68
Update domain-modeling-tools.md
sideeffffect 0361062
Update binary-compatibility-for-library-authors.md
sideeffffect 3b1fc57
Update binary-compatibility-for-library-authors.md
sideeffffect 6b8b157
Update domain-modeling-tools.md
sideeffffect 75b5937
Update binary-compatibility-for-library-authors.md
sideeffffect 1118fb3
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect 64776be
Update binary-compatibility-for-library-authors.md
sideeffffect b583d46
Update binary-compatibility-for-library-authors.md
sideeffffect a6d4fc0
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect 85bf8e7
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect 359219e
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect 25af00f
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect b328958
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect caaa532
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect 9afdd84
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect 7806dbd
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect a764a9c
Update binary-compatibility-for-library-authors.md
sideeffffect a52d7d6
Update binary-compatibility-for-library-authors.md
sideeffffect 7668763
Apply suggestions from code review
sideeffffect 293a0bd
Update binary-compatibility-for-library-authors.md
sideeffffect 5c1d9b3
Update _overviews/tutorials/binary-compatibility-for-library-authors.md
sideeffffect 4f548e9
Apply suggestions from code review
sideeffffect f3e6c15
Revert "Apply suggestions from code review"
julienrf 3ab5b4b
Final adjustments
julienrf a818702
Actual final adjustments
julienrf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't a binary compatible change, right? You're removing the method
apply
that takes 2 parameters.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, you're not removing anything. You're only adding new stuff. That's the point.
Unless I missed something 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh sorry, I assumed this was replacing the
apply
present before. Of course you're right