Rewrite rule for Map#mapValues should call .view

[NthPortal]

Rewrite rule for Map#mapValues should call .view before calling .mapValues (H/T @joshlemer)

[ekrich]

This involves the same code but requesting that we have a way to update the code to remove the deprecation and still compile against 2.11 and 2.12.

[warn] /Users/eric/workspace/sconfig/sconfig/jvm/src/test/scala/org/ekrich/config/impl/PublicApiTest.scala:170:8: method mapValues in trait MapOps is deprecated (since 2.13.0): Use .view.mapValues(f). A future version will include a strict version of this method (for now, .view.mapValues(f).toMap).
[warn]       .mapValues(intValue(_): AbstractConfigValue)

The code in question:

val aMapValue = Map("a" -> 1, "b" -> 2, "c" -> 3)
      .mapValues(intValue(_): AbstractConfigValue)
      .toMap

[joshlemer]

It's also probably worth pointing out that .transform((_, v) => f(v)) is going to be a lot more efficient than .view.mapValues(f).toMap

[NthPortal]

@joshlemer yes, but that's a less straightforward rewrite, due to having to rewrite the function too

[ekrich]

I only had that in the code base 3 places so it certainly is an easy workaround for me.

• Eliminated deprecation warning on 2.13
• Works on 2.11, 2.12, and 2.13

I would never thought of it though.