Scala 2.13.4

[sullis]

No description provided.

[SethTisue]

@sullis is the same failure that's happening in CI happening for you locally...?

[SethTisue]

Well this is discouraging. The failure on Travis happens every time. Locally, I have seen the same failure, but it doesn't happen every time, and at the moment it isn't happening at all.

Lord knows if this even has anything to do with the 2.13.4 upgrade.

[SethTisue]

[error] /home/travis/build/scala/scala-java8-compat/target/java/scala/concurrent/java8/FuturesConvertersImpl$.java:3:1:  error: unknown tag: inheritdoc
[error]  * @inheritdoc
[error]    ^
[error] /home/travis/build/scala/scala-java8-compat/target/java/scala/compat/java8/DurationConverters.java:7:1:  error: invalid use of @throws
[error]  * @throws IllegalArgumentException If the given Java Duration is out of bounds of what can be expressed with the
[error]    ^
[error] /home/travis/build/scala/scala-java8-compat/target/java/scala/compat/java8/DurationConverters$.java:7:1:  error: invalid use of @throws
[error]  * @throws IllegalArgumentException If the given Java Duration is out of bounds of what can be expressed with the
[error]    ^

related to lightbend/genjavadoc#59 ?

but then also:

[error] /home/travis/build/scala/scala-java8-compat/target/java/scala/compat/java8/FutureConverters.java:14:1:  error: invalid use of @return
[error]  * @return a CompletionStage that runs all callbacks asynchronously and does
[error]    ^
[error] /home/travis/build/scala/scala-java8-compat/target/java/scala/compat/java8/FutureConverters.java:53:1:  error: invalid use of @return
[error]    * @return a Scala Future that represents the CompletionStage's completion
[error]      ^

[SethTisue]

well I never got to the bottom of this — I stopped seeing it locally, though I'm sure I had, before, at least a couple times — but -Xdoclint:none allows us to proceed regardless

or maybe the problem randomly perturbed itself out of existence and -Xdoclint:none wasn't actually the fix? THE SHADOW KNOWS

[SethTisue]

merge build at https://travis-ci.com/github/scala/scala-java8-compat/builds/215169038 also green, mercifully