This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Improvements for the Scala SBT build #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we'll fall back to the non-existent scala-xml 1.0.4 when bootstrapping the modules with new releases of Scala 2.12.
Currently, only tests based in `test/files/...` can be tested in partest through SBT. This commit will honour `--srcpath scaladoc`, for example, before defaulting to `files`.
|
The second commit intends to fix scala/scala-partest-interface#14 |
|
I've tested this out locally: To automate running the scaladoc tests, I think we'll need to create another config (alongside |
retronym
added a commit
to retronym/scala
that referenced
this pull request
Feb 6, 2016
We can complete partest options (I've excluded some that aren't relevant in SBT), as well as test file names. If `--srcpath scaladoc` is included, completion of test paths will be based on `test/scaladoc` rather than the default `test/files`. Note that the `--srcpath` option is currently broken via scala partest interface, this change to scala-partest is needed to make it work: scala/scala-partest#49 I've also hijacked the `--grep` option with logic in the SBT command itself, rather than passing this to `partest`. Just like `./bin/partest-ack`, this looks for either test file names or regex matches within the contents of test, check, or flag files. I tried for some time to make the tab completion of thousands of filenames more user friendly, but wasn't able to get something working. Ideally, it should only suggest to `test/files/{pos, neg, ...}` on the first <TAB>, and then offer files on another TAB. Files should also be offered if a full directory has been entered. Hopefully a SBT parser guru will step in and add some polish here.
|
LGTM. Honoring For a proper integration of the scaladoc tests we should reconsider SBTRunner's We may want to change the project/config scoping for tests in the sbt build as well. Adding configs is a bit ugly, so I'd rather go for a separate project. Do we even need to use the |
That would be the principled approach, but in the meantime we just need our CI to call
That sounds like a good idea. |
retronym
added a commit
that referenced
this pull request
Feb 9, 2016
Improvements for the Scala SBT build
janekdb
pushed a commit
to janekdb/scala
that referenced
this pull request
Feb 11, 2016
We can complete partest options (I've excluded some that aren't relevant in SBT), as well as test file names. If `--srcpath scaladoc` is included, completion of test paths will be based on `test/scaladoc` rather than the default `test/files`. Note that the `--srcpath` option is currently broken via scala partest interface, this change to scala-partest is needed to make it work: scala/scala-partest#49 I've also hijacked the `--grep` option with logic in the SBT command itself, rather than passing this to `partest`. Just like `./bin/partest-ack`, this looks for either test file names or regex matches within the contents of test, check, or flag files. I tried for some time to make the tab completion of thousands of filenames more user friendly, but wasn't able to get something working. Ideally, it should only suggest to `test/files/{pos, neg, ...}` on the first <TAB>, and then offer files on another TAB. Files should also be offered if a full directory has been entered. Hopefully a SBT parser guru will step in and add some polish here.
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Improvements for the Scala SBT build
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Improvements for the Scala SBT build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @szeiger or @SethTisue