This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Add synchronization when sending events to sbt (fix ArrayIOBException). #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partest shows a single `Task` to sbt and does all the concurrency and running subtasks itself, which isn't really how this should work, so sbt doesn't expect the task to send back events concurrently: `EventHandler.handle` adds events to an `ArrayList` when forking (see [ForkMain][2]), and is called after each test, and if it happens on two threads at exactly the wrong moment: ``` Caused by: sbt.ForkMain$ForkError: java.lang.ArrayIndexOutOfBoundsException: 15 at java.util.ArrayList.add(ArrayList.java:459) at sbt.ForkMain$Run$2$1.handle(ForkMain.java:294) at scala.tools.partest.sbt.SBTRunner$$anon$1.onFinishTest(SBTRunner.scala:70) at scala.tools.partest.nest.SuiteRunner.runTest(Runner.scala:781) at scala.tools.partest.nest.SuiteRunner.$anonfun$runTestsForFiles$2(Runner.scala:788) at scala.tools.partest.package$$anon$2.call(package.scala:135) ``` See scala/scala#5663 ([build log][1] or the failed run). [1]: https://scala-ci.typesafe.com/job/scala-2.12.x-validate-test/4300/consoleFull [2]: https://github.com/sbt/sbt/blob/v0.13.13/testing/agent/src/main/java/sbt/ForkMain.java#L294
|
This could also be fixed on sbt's side, but it probably wouldn't benefit anyone else: a reasonable test framework's I'm running locally the tests on the scala repo with this change, to see if it slows down anything... |
|
And this was my "let's chase this interesting error" day 😄 |
|
Very interesting. Thank you for looking into this and sharing your analysis. |
|
Thanks! Sorry for the delay in merging this 😞 |
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Add synchronization when sending events to sbt (fix ArrayIOBException).
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Add synchronization when sending events to sbt (fix ArrayIOBException).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partest shows a single
Taskto sbt and does all the concurrency andrunning subtasks itself, which isn't really how this should work, so sbt
doesn't expect the task to send back events concurrently:
EventHandler.handleadds events to anArrayListwhen forking (seeForkMain), and is called after each test, and if it happens on two
threads at exactly the wrong moment:
See scala/scala#5663 (build log or the failed run).