turn remainder of the pos/run/jvm partest tests into JUnit ones #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See scala/scala#3135 |
|
We can use the toolbox compiler to do this. Alternatively, we can could use Here's how we do it in https://github.com/scala/async/blob/master/src/test/scala/scala/async/package.scala#L34 I suspect it will be even easier here as the manual classpath setting was only needed to |
Most of the pos tests were incorporated in the ShouldCompile 'unit test'. The others are going back to scala/scala. I was a bit overzealous in moving stuff over to scala-xml in scala/scala#9c50dd5. These were all compiler tests that accidentally touched on xml. I've tried to delicately decouple them so they can roam the scalac pastures as intended.
adriaanm
added a commit
that referenced
this pull request
Nov 19, 2013
turn remainder of the pos/run/jvm partest tests into JUnit ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too bad we can't get rid of those neg tests. Any macro-thoughts, @retronym?
corresponding PR to bring back some tests coming soon at scala/scala
review by @gkossakowski