fix #11764: generic sums can have no children #15010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
Apr 25, 2022
|
so, it seems that in the community build ProtoQuill ( |
bishabosha
added
the
needs-minor-release
|
so because apparently libraries have been build upon the assumption that sum types do have at least one child, then I guess this should only go in a minor release, if at all. One would have to make the case that the status quo is more inconvenient. @japgolly what do you think? One solution that could be less disruptive is to introduce another subclass of |
|
we decided its not worth the pain with the libraries already working on the assumption that a Sum has minimum 1 child. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11764
enable generic sum types to have no children, while also asserting that it is not a
sealed abstract case class.