-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix #11764: generic sums can have no children #15010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
-- Error: tests/neg/i11764.scala:20:38 --------------------------------------------------------------------------------- | ||
20 | val mFoo = summon[Mirror.SumOf[Foo]] // error | ||
| ^ | ||
|no given instance of type deriving.Mirror.SumOf[Foo] was found for parameter x of method summon in object Predef | ||
-- Error: tests/neg/i11764.scala:22:38 --------------------------------------------------------------------------------- | ||
22 | val mBar = summon[Mirror.SumOf[Bar]] // error | ||
| ^ | ||
|no given instance of type deriving.Mirror.SumOf[Bar] was found for parameter x of method summon in object Predef | ||
-- Error: tests/neg/i11764.scala:23:42 --------------------------------------------------------------------------------- | ||
23 | val mBaz = summon[Mirror.ProductOf[Bar]] // error | ||
| ^ | ||
|no given instance of type deriving.Mirror.ProductOf[Bar] was found for parameter x of method summon in object Predef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import deriving.Mirror | ||
|
||
// a sealed trait with inaccessible children should | ||
// still not be a generic sum. | ||
sealed trait Foo | ||
object Foo { | ||
def local = | ||
case class Local() extends Foo | ||
} | ||
|
||
// in `3.0-3.1`, sealed abstract case class was neither a | ||
// generic sum type (because it can't have `case` children), | ||
// or a generic product type (because we can't call the ctor), | ||
// but now sum types can have no children, | ||
// so we must restrict against case classes. | ||
sealed abstract case class Bar() | ||
|
||
def foo = | ||
|
||
val mFoo = summon[Mirror.SumOf[Foo]] // error | ||
|
||
val mBar = summon[Mirror.SumOf[Bar]] // error | ||
val mBaz = summon[Mirror.ProductOf[Bar]] // error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import deriving.Mirror | ||
|
||
sealed trait Foo | ||
object Foo | ||
|
||
sealed trait Bar | ||
|
||
|
||
@main def Test = | ||
val mFoo = summon[Mirror.SumOf[Foo]] | ||
assert(mFoo eq Foo) | ||
summon[mFoo.MirroredElemTypes =:= EmptyTuple] | ||
|
||
val mBar = summon[Mirror.SumOf[Bar]] // also check anonymous case | ||
summon[mBar.MirroredElemTypes =:= EmptyTuple] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.