Fix #10082: show friendly error message related to type inference #10100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Oct 27, 2020
smarter
reviewed
Oct 30, 2020
| @@ -509,6 +509,8 @@ trait Inferencing { this: Typer => | |||
| // required: String | |||
| // val y: List[List[String]] = List(List(1)) | |||
| val hasUnreportedErrors = state.reporter.hasUnreportedErrors | |||
| if hasUnreportedErrors then return tree | |||
There was a problem hiding this comment.
@odersky Any reason we previously still instantiated some type variables when hasUnreportedErrors is true?
odersky
reviewed
Oct 30, 2020
| @@ -509,6 +509,8 @@ trait Inferencing { this: Typer => | |||
| // required: String | |||
| // val y: List[List[String]] = List(List(1)) | |||
| val hasUnreportedErrors = state.reporter.hasUnreportedErrors | |||
| if hasUnreportedErrors then return tree | |||
| @@ -509,6 +509,8 @@ trait Inferencing { this: Typer => | |||
| // required: String | |||
| // val y: List[List[String]] = List(List(1)) | |||
| val hasUnreportedErrors = state.reporter.hasUnreportedErrors | |||
There was a problem hiding this comment.
No need to define a local variable, it seems. We can simply return if state.reporter.hasUnreportedErrors is true.
The type `site` in class `NotAMember` might be an uninitialized type variable, but is initialized when we display the error message. It results in confusing error message as in scala#10082. We avoid instantiating the type variable when there is a unreported error in current typerstate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10082: show friendly error message related to type inference