-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[docs/reference] more fixes in Markdown files #10860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @michelou 👍
@@ -196,6 +196,8 @@ private def dynamicPower(x: Double, n: Int): Double = | |||
else x * dynamicPower(x, n - 1) | |||
``` | |||
|
|||
This assumes a `.value` that maps tree nodes representing constants to their values. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be not necessary, as .value
indeed exists in stdlib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes from @nicolasstucki's suggestion (see his comment in PR #10826).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change it to something like the following:
In the above, the method
.value
maps a constant expression of the typeExpr[T]
to its value of the typeT
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (see below).
@SethTisue I bet you will like the following changes in
|
@michelou I would like to tweet about the existence of this PDF. Should I use the https://github.com/michelou/dotty-examples/blob/master/docs/scala3_reference.pdf URL, or is there a plan to have it live in a more "official" location? |
@SethTisue I have another PR pending. Again I will assign @liufengyun as reviewer and I will ask him to rule on a more "official" location. |
Follow up of PR #10767 and PR #10826.
Fixes more issues found in Markdown files in
docs/reference/
, e.g,PS. The above changes can also be viewed in the PDF document
scala3_reference.pdf
(734 Kb) generated with Pandoc 2.11.