Docs cleanups #10878
Merged
Docs cleanups #10878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix outdated syntax - Switch to indentation syntax almost everywhere - Explain soft keywords in detail - Switch to 3 space indent The switch to 3 space is an experiment, we can undo it separately if we don;t like it.
`new ... with` is currently under discussion, but not supported.
b-studios
suggested changes
Dec 22, 2020
b-studios
suggested changes
Dec 22, 2020
| case "string" => '{"a"} | ||
| strExpr.valueOrError match | ||
| case "int" => '{1} | ||
| case "string" => '{"a"} |
There was a problem hiding this comment.
Here is a match that is not indented as the others.
| def setForExpr[T: Type](using Quotes): Expr[Set[T]] = | ||
| Expr.summon[Ordering[T]] match | ||
| case Some(ord) => '{ new TreeSet[T]()($ord) } | ||
| case _ => '{ new HashSet[T] } |
There was a problem hiding this comment.
Here is a match that is not indented as the others.
| } | ||
| private def sumExpr(argsExpr: Expr[Seq[Int]])(using Quotes): Expr[Int] = | ||
| argsExpr match | ||
| case Varargs(args @ Exprs(argValues)) => |
There was a problem hiding this comment.
Here is another match that is not indented as the others.
Co-authored-by: Jonathan <[email protected]> Co-authored-by: Lan, Jian <[email protected]>
b-studios
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch to 3 space is an experiment, we can undo it separately if we don;t like it.