Skip to content

Fix presentation of signature types that may change in inherited classes due to different symbolic type names/partially applied types #11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2021

Conversation

BarkingBad
Copy link
Contributor

No description provided.

Copy link
Contributor

@romanowski romanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will looks ok when we will move the casting to compiler internals

@BarkingBad BarkingBad force-pushed the scala3doc/type-parameters-fix branch from acc399a to 8bebec3 Compare January 12, 2021 13:52
@BarkingBad BarkingBad force-pushed the scala3doc/type-parameters-fix branch from 8bebec3 to 3203cb2 Compare January 12, 2021 15:08
@BarkingBad BarkingBad force-pushed the scala3doc/type-parameters-fix branch from 3203cb2 to 594652f Compare January 12, 2021 15:10
@BarkingBad BarkingBad requested a review from romanowski January 13, 2021 11:08
Copy link
Contributor

@romanowski romanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions and suggestions

Copy link
Contributor

@pikinier20 pikinier20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@BarkingBad BarkingBad merged commit 3e85fca into scala:master Jan 15, 2021
@BarkingBad BarkingBad deleted the scala3doc/type-parameters-fix branch January 15, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants