Fix cast exception while traversing supertypes in Scala3doc #11123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarkingBad
force-pushed
the
scala3doc/typedef-defdef-issues
branch
from
5b80a73 to
3b94638
Compare
| Seq(link -> superLink) ++ getSupertypesGraph(tree.asInstanceOf[ClassDef], superLink) | ||
| } | ||
| ) | ||
| val parents = unpackTreeToClassDef(classDef).asInstanceOf[ClassDef].parents |
There was a problem hiding this comment.
I would make unpackTreeToClassDef return a ClassDef instead of the unchecked cast.
In unpackTreeToClassDef you can do
- case c: Apply => c.symbol.owner.tree.symbol.tree
+ case c: Apply =>
+ c.symbol.owner.tree.symbol.tree match
+ case tree: ClassDef => tree
BarkingBad
force-pushed
the
scala3doc/typedef-defdef-issues
branch
from
3b94638 to
88c1548
Compare
romanowski
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.