Skip to content

Fix BootstrappedOnlyCompilationTests error reporting #11125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jan 14, 2021

Now it lists the failed tests at the end.

Code ported from CompilationTests.scala. See f974707.

Now it lists the failed tests at the end.

Code ported from `CompilationTests.scala`
@nicolasstucki nicolasstucki marked this pull request as ready for review January 14, 2021 15:09
@nicolasstucki
Copy link
Contributor Author

Failures should be shown in this other PR https://github.com/lampepfl/dotty/runs/1702532363. They were shown when running tests locally.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 6750f0e into scala:master Jan 18, 2021
@liufengyun liufengyun deleted the fix-BootstrappedOnlyCompilationTests-reporting branch January 18, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants