Skip to content

handle export forwarders in Scala.js #12611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2021
Merged

handle export forwarders in Scala.js #12611

merged 2 commits into from
May 28, 2021

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented May 26, 2021 •
edited
Loading

  • prevent export forwarders in JS native types and JS non-native traits
  • remove annotations js.native, js.annotation.* from export forwarders
    in PrepJSInterop

fixes #12111

@bishabosha bishabosha requested a review from sjrd May 26, 2021 16:19
@bishabosha bishabosha force-pushed the fix-12111 branch 2 times, most recently from 47ffc63 to 61c5b5e Compare May 26, 2021 16:26
sjrd
sjrd requested changes May 27, 2021
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can an export definition be annotated itself? If yes, we should also forbid JS annotations on exports.

@bishabosha
handle export forwarders in Scala.js
ce351db 
- prevent export forwarders in JS Native types
- remove annotations js.native, js.annotation.*
  from export forwarders in PrepJSInterop
@bishabosha
Copy link
Member Author

@sjrd I have added a 'hack' for detecting if we are in a non-native JS trait

@bishabosha bishabosha requested a review from sjrd May 27, 2021 13:37
sjrd
sjrd requested changes May 28, 2021
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The logic looks good now. I have mostly a suggestion to turn your "hack" into properly fitting in the design.

@bishabosha bishabosha force-pushed the fix-12111 branch 2 times, most recently from 4cdd310 to 3a91c59 Compare May 28, 2021 09:11
@bishabosha bishabosha requested a review from sjrd May 28, 2021 09:12
@bishabosha bishabosha enabled auto-merge May 28, 2021 09:25
@bishabosha bishabosha merged commit c95cc72 into scala:master May 28, 2021
@bishabosha bishabosha deleted the fix-12111 branch May 28, 2021 10:39
@Kordyjan Kordyjan added this to the 3.0.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

Exporting JS facades fails
3 participants
@bishabosha @sjrd @Kordyjan