Add recheck phase #12971
Merged
Add recheck phase #12971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
reviewed
Jun 28, 2021
| @@ -1161,6 +1160,37 @@ class Typer extends Namer | |||
| } | |||
| } | |||
|
|
|||
| /** The parameter type for a parameter in a lambda that does | |||
| * not have an explicit type given, and where the type is not known from the context. | |||
| * In this case the paranmeter type needs to be inferred the "target type" T known | |||
There was a problem hiding this comment.
Spelling
Suggested change
| * In this case the paranmeter type needs to be inferred the "target type" T known | |
| * In this case the parameter type needs to be inferred from the "target type" T known |
|
#12938 now merged |
|
Squashed to one commit and rebased to master |
… program. This is useful for two reasons: = It gives us additional explanation and validation what constitutes a well-typed Scala 3 program. Recheck has less than 300 lines of code, which is a lot less than Typer and associated files. - It can be used as a basis for phases that refine the original types with new kinds of types and new rules.
|
@olhotak Wpuld you be interested in reviewing this? I think it is ready to merge. |
olhotak
reviewed
Aug 11, 2021
|
|
||
| def run(using Context): Unit = | ||
| val unit = ctx.compilationUnit | ||
| //println(i"recheck types of $unit") |
| def recheckBind(tree: Bind, pt: Type)(using Context): Type = tree match | ||
| case Bind(name, body) => | ||
| enterDef(tree) | ||
| val bodyType = recheck(body, pt) |
There was a problem hiding this comment.
Is it intentional that bodyType is unused?
There was a problem hiding this comment.
Yes. But I am not completely sure how to handle that. Generally, Binds will be gone by the time the rechecker is run, except for type binds.
This is necessary since not all constant folded terms are converted to literals. The conversion does not happen if one of the operands is impure. A test case is run/final-field.scala
Detected when fixing the conforms check
- rename `exludes` --> `excludes` - fix comments
smarter
requested changes
Aug 13, 2021
Treat a SolemType(T) as a supertype (as well as a subtype) of T.
smarter
reviewed
Aug 13, 2021
| * - being able to compile dotty bootstrapped, | ||
| * - making sure that TASTY can link against a compiled version of Dotty, | ||
| * - compiling the compiler using the SemanticDB generation | ||
| * - compiling the compiler under -Yrecheck mode. |
There was a problem hiding this comment.
Can -Yrecheck be thought of as a more extensive -Ycheck or do they end up checking different things?
There was a problem hiding this comment.
Quite different things. -Yrecheck is only for testing special recheck phases. Right now there is only one such phase planned, and that is the capture checker. But others might follow.
|
LGTM now. |
bishabosha
added a commit
that referenced
this pull request
Aug 17, 2021
Revert "Merge pull request #12971 from dotty-staging/add-rechecker"
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 1, 2021
Add recheck phase
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 24, 2021
Add recheck phase
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Oct 2, 2021
Add recheck phase
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Dec 11, 2021
Add recheck phase
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Aug 29, 2022
Add recheck phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a phase for recomputing and rechecking all types in a typed Scala program. This is useful for two reasons:
Based on #12938