Upgrade Java version in community-build #16412
Conversation
nicolasstucki
force-pushed
the
upgrade-java-in-community-build
branch
2 times, most recently
from
56adb20 to
621ba3e
Compare
|
|
.github/workflows/ci.yaml
Outdated
| ) | ||
| || ( | ||
| github.event_name == 'workflow_dispatch' | ||
| && github.repository == 'lampepfl/dotty' | ||
| )" | ||
|
|
||
| steps: | ||
| - name: Set JDK 17 as default | ||
| run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH |
There was a problem hiding this comment.
I don't think Java 17 is installed on the docker image we're currently running, so this might not do anything
There was a problem hiding this comment.
The Dockerfile was updated in October 2021: lampepfl/dotty-ci#19, but the image we're running is from March 2021: https://github.com/lampepfl/dotty/blob/main/.github/workflows/ci.yaml#L37
There was a problem hiding this comment.
I changed it to JDK 16. We can update it when we update the image.
How do we update that image?
There was a problem hiding this comment.
To push a new image, see instructions in https://github.com/lampepfl/dotty-ci#dotty-docker-image, then the ci.yaml file can be updated to point to the new one.
nicolasstucki
force-pushed
the
upgrade-java-in-community-build
branch
from
621ba3e to
67a511f
Compare
| ) | ||
| || ( | ||
| github.event_name == 'workflow_dispatch' | ||
| && github.repository == 'lampepfl/dotty' | ||
| )" | ||
|
|
||
| steps: | ||
| - name: Set JDK 15 as default |
There was a problem hiding this comment.
I don't think the image has JDK 15 either, just JDK 16 and JDK 8 as the default, so this probably doesn't do anything.
[skip test]
[skip test_windows_fast]
[skip test_sbt]
[skip mima]
[skip docs]