Skip to content

Fix: Remove the duplicate logo #17170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix: Remove the duplicate logo #17170

merged 1 commit into from
Mar 30, 2023

Conversation

Dedelweiss
Copy link
Contributor

@Dedelweiss Dedelweiss commented Mar 29, 2023 •
edited
Loading

  • I added an orElse to the snippet so that the dark logo works and there is no duplicate logo.

Before

Screenshot 2023-03-29 at 14 51 09

### After

Screenshot 2023-03-29 at 14 48 22

Fixes: #16693

@Dedelweiss Dedelweiss changed the title Remove the duplicate logo Fix: Remove the duplicate logo Mar 29, 2023
@Dedelweiss Dedelweiss mentioned this pull request Mar 29, 2023
Closed
ckipp01
ckipp01 requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Just a small note on removing the other orElse now that you've added it sooner.

@Dedelweiss
Remove the duplicate logo
4d9dc54 
- I added an orElse to the snippet
ckipp01
ckipp01 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@ckipp01 ckipp01 enabled auto-merge (squash) March 30, 2023 13:16
@ckipp01 ckipp01 merged commit cabfa68 into scala:main Mar 30, 2023
@Dedelweiss Dedelweiss deleted the project_logo branch March 30, 2023 14:07
Dedelweiss added a commit to Dedelweiss/dotty that referenced this pull request Apr 17, 2023
@Dedelweiss
Fix: Remove the duplicate logo (scala#17170)
746cc13 
- I added an orElse to the snippet so that the dark logo works and there
is no duplicate logo.
### Before
<img width="569" alt="Screenshot 2023-03-29 at 14 51 09"
src="https://user-images.githubusercontent.com/44496264/228541357-77ca6c2a-4413-45fd-a283-40f304d88c4a.png">
### After 
<img width="569" alt="Screenshot 2023-03-29 at 14 48 22"
src="https://user-images.githubusercontent.com/44496264/228541334-c9a3eccc-1d4a-475b-b03b-3698bde162fb.png">

Fixes: scala#16693
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

scaladoc inserts -project-logo twice
3 participants
@Dedelweiss @ckipp01 @Kordyjan