Fix incorrect comment parser used in nightly scaladoc #18523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a sourceDirectory sbt task would resolve to "library/src/main" which usually would be correct, but in the case of the scala 3 library, we have the sources directly under `library/src` This lead to the fact that the incorrectly set `-comment-syntax` option could never match against the prefix for markdown, and would use the wiki syntax for all scala3-library sources.
nicolasstucki
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a
sourceDirectorysbt task would resolve tolibrary/src/mainwhich would usually be correct, but in the case of scala3-library, we have the sources directly underlibrary/src. This lead to the fact that the incorrectly set-comment-syntaxoption could never match against the prefix for markdown, and would use the wiki syntax for all scala3-library sources.Fixes #18511