Bring back pattern match exhaustivity checking for macros #22622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move the -Werror reporting until after the suspended warning reporting - this was needed for the added test to work (as previously the compilation would not error out even if -Werror was used).
|
@dwijnand Is that something we can do? I saw that the changes in 4f22672 were intentional. Unlike reachability, it's easy enough to suppress exhaustivity checks on the user side in macros (and, if left disabled in the compiler, implementing those checks on the user side seems difficult). What do you think? |
dwijnand
approved these changes
Mar 3, 2025
|
Thank you @dwijnand! I will admit I did not know it was possible to have tests with macro execution in nonBootstrapped test runs. I see there are more of these (like in tests/run), even though most macro tests are in bootstrapped-only versions (like tests/run-macros). I will have to check why that is. I will probably also have to file an issue for the -Werror not working here, but I can do that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move the
-Werrorreporting until after the suspended warning reporting - this was needed for the added test to work (as previously the compilation would not error out even if-Werrorwas used).Fixes #22212